Skip to content

Remove broken link in pvsystem.retrieve_sam#2312

Merged
kandersolar merged 3 commits into
pvlib:mainfrom
RDaxini:dead_links
Dec 3, 2024
Merged

Remove broken link in pvsystem.retrieve_sam#2312
kandersolar merged 3 commits into
pvlib:mainfrom
RDaxini:dead_links

Conversation

@RDaxini

@RDaxini RDaxini commented Nov 27, 2024

Copy link
Copy Markdown
Member

If I understood correctly, the conclusion in #2288 is to remove the links entirely rather than update the second one with https://sam.nrel.gov/photovoltaic/pv-publications.html (?)

@RDaxini RDaxini added this to the v0.11.2 milestone Nov 27, 2024
Comment thread pvlib/pvsystem.py

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RDaxini!

@kandersolar kandersolar merged commit f5002c7 into pvlib:main Dec 3, 2024
@RDaxini RDaxini deleted the dead_links branch December 3, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link in pvsystem.retrieve_sam

3 participants